search

wkhtmltopdf / packaging

Packaging of wkhtmltopdf releases
https://wkhtmltopdf.org/downloads.html#stable
308 stars 141 forks source link

Support Ubuntu 22.04 Jammy Jellyfish #115

Closed pfumagalli closed 2 years ago

pfumagalli commented 2 years ago

The new Ubuntu LTS 22.04 was released on 21 April 2022, this small patch enables support for it.

ashkulz commented 2 years ago

@pfumagalli does this work? I think you need to have some patches for Qt 4 for it to compile.

pfumagalli commented 2 years ago

Huh???

You patched it last week!

https://github.com/wkhtmltopdf/qt/commit/bb81921302fec10702d0d864d8d440fa0fe91900

ashkulz commented 2 years ago

That's exactly what I meant, but it's not part of any official release yet. I'm working on Ubuntu 22.04 and Debian 11 support, but haven't gotten time to finish porting to GH Actions.

I think it should work with gcc10, not sure why you used gcc9?

pfumagalli commented 2 years ago

I needed a version of 0.12.5 for ARM64, running on Jammy (installing Odoo on Graviton) so I cherry picked bb81921, ac069f4, 61e4464, and 7480f44 on my tree and compiled...

I used GCC 9 because when I started (before your commits) I was using https://aur.archlinux.org/cgit/aur.git/tree/qt4-gcc9.patch?h=qt4 and felt it was the safest option. I haven't tried 10 or 11 (Jammy's default).

chrira commented 2 years ago

This PR would fix #114 We are also looking forward to get a release for Ubuntu 22.04 (jammy)

ashkulz commented 2 years ago

I'm first trying to move to GitHub Actions, after which I can look at this and #101

ashkulz commented 2 years ago

Thanks for the contribution, @pfumagalli! I've started building the packages and hopefully should be published by tomorrow :+1:

ashkulz commented 2 years ago

Builds have been published to the website: see wkhtmltopdf/wkhtmltopdf@e59bfcce3e8db83341264bdd75d996319402ccff.