search

wkhtmltopdf / packaging

Packaging of wkhtmltopdf releases
https://wkhtmltopdf.org/downloads.html#stable
301 stars 136 forks source link

Support RHEL9-based OSes #118

Closed der-eismann closed 2 years ago

der-eismann commented 2 years ago

Since CentOS 8 was EOL'd at the end of 2021 we should replace the image with almalinux:8 or rockylinux:8. I chose the former because they already have released version 9, which builds up on RHEL 9. This release is using GCC 11, so we probably need to wait until the https://github.com/wkhtmltopdf/qt/commit/bb81921302fec10702d0d864d8d440fa0fe91900 patch is released.

Fixes #119

ashkulz commented 2 years ago

@der-eismann can you split this into two commits (one for CentOS 8 => AlmaLinux 8, second for AlmaLinux 9)? Also, I would appreciate if you confirmed if this actually worked with the 0.12.6.x branch, which should have the above patches.

der-eismann commented 2 years ago

@der-eismann can you split this into two commits (one for CentOS 8 => AlmaLinux 8, second for AlmaLinux 9)?

Just opened #120, will test the rest.

ashkulz commented 2 years ago

@der-eismann you'll need to rebase this branch since I merged your other PR.

ashkulz commented 2 years ago

Thanks for the contribution, @der-eismann! I've started building the packages and hopefully should be published by tomorrow :+1:

der-eismann commented 2 years ago

I'm sorry that I wasn't able to finish it, thanks for finishing!

der-eismann commented 2 years ago

@ashkulz I noticed that there is a small copy-paste error: For the AlmaLinux 9 build you used the almalinux:8 container image.

ashkulz commented 2 years ago

@der-eismann I've pushed a fix. Today is not my day.