search

wkhtmltopdf / packaging

Packaging of wkhtmltopdf releases
https://wkhtmltopdf.org/downloads.html#stable
301 stars 136 forks source link

[FIX] actually build jammy, not bionic #122

Closed StefanRijnhart closed 2 years ago

StefanRijnhart commented 2 years ago

Fixes: #121

StefanRijnhart commented 2 years ago

Well, more embarrasment on my side, I'm now actually trying to build wkhtmltox for the first time myself, and it seems that Jammy needs to install python3 instead of python in its dockerfile. I can propose a fix (once I managed to run the build successfully myself), but what would be the best way to codify this? Would you like a new Dockerfile.debian.python3 with the packages swapped out?

Package python is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
However the following packages replace it:
  python2-minimal python2 dh-python 2to3 python-is-python3
ashkulz commented 2 years ago

@StefanRijnhart I canceled the run to build the binaries. I think the cleanest way is to add an ARG python=python at the start of Dockerfile.debian and pass in python: python-is-python3 in build.yml which should hopefully pull in python3 as well.

ashkulz commented 2 years ago

Let me know if you figure it out, else I'll see if I can do it early tomorrow -- have a birthday in the family today :smile:

StefanRijnhart commented 2 years ago

@ashkulz thank you for your guidance. Using an ARG for the python package seems to work. Will propose when the build has finished. Please prioritize family, it is important.

StefanRijnhart commented 2 years ago

https://github.com/wkhtmltopdf/packaging/pull/123