search

wkhtmltopdf / packaging

Packaging of wkhtmltopdf releases
https://wkhtmltopdf.org/downloads.html#stable
308 stars 141 forks source link

Adds Fedora 37 build target making use of existing Dockerfile.centos #136

Closed innovara closed 1 year ago

innovara commented 1 year ago

This is an amended version of my previous PR https://github.com/wkhtmltopdf/packaging/pull/135

With these changes, it is possible to build wkhtmltopdf for Fedora 37. There are no extra dependencies required compared to CentOS 7 so it uses the the existing Dockerfile.centos

ashkulz commented 1 year ago

Thanks for the contribution, @innovara!

ashkulz commented 1 year ago

@innovara published a new release 0.12.6.1-3, the aarch64 build is still ongoing due to hitting the 6-hour cutoff.

innovara commented 1 year ago

@ashkulz I used native aarch64 to build it (Raspberry Pi 4) and my recollection is that it took a while but it completed much sooner than that. I'm doing it again to provide a more precise benchmark. Obviously it's a totally different story using emulating aarch64 on x86_64 with qemu. I see that Alma Linux 8 and 9 complete under 5 hours for aarch64 but I don't think there's much you can do in this situation apart from dropping aarch64 for Fedora. Maybe unrelated, but have you thought of using ubuntu-22.04 for the build instead of ubuntu-20.04? I reckon a newer (but stable) version of qemu will bring performance gains on emulated architectures. It's highly speculative and maybe not worth the risk of potentially causing issues with other targets.

ashkulz commented 1 year ago

From what I recall, there was a regression in performance when I checked it a few months ago but I could be wrong.