search

wkhtmltopdf / packaging

Packaging of wkhtmltopdf releases
https://wkhtmltopdf.org/downloads.html#stable
311 stars 142 forks source link

Don't use `os.path.abspath` for rsync command line #71

Closed tyomitch closed 4 years ago

tyomitch commented 4 years ago

On Windows, rsync has to be passed relative paths, because it parses the colon as host name separator.

ashkulz commented 4 years ago

@tyomitch: can you let me know what your setup was? I'm pretty sure this worked earlier with both the Vagrant image and the Azure Pipelines setup, so would like to understand how it's not working for you.

tyomitch commented 4 years ago

I was building msvc2015-win64 on a Windows host.

ashkulz commented 4 years ago

Then you don't need to do a rsync at all! You can refer to the Azure Pipelines configuration on how to set up and execute it.

I think I should document that only Linux is supported on the requirements in README -- thought it was implied 🙈

tyomitch commented 4 years ago

Then you don't need to do a rsync at all! You can refer to the Azure Pipelines configuration on how to set up and execute it.

To clarify, I'm not doing any rsync myself: the build script (invoked from L173 of the Azure Pipelines configuration) does it.

ashkulz commented 4 years ago

@tyomitch: the script does things in two phases:

So if you pass a --version then in starts from point 2, which is what the pipeline configuration also does. I haven't tested the VM approach recently -- were you using a VM as well?

tyomitch commented 4 years ago

Yes, I was building with Vagrant / VirtualBox.

ashkulz commented 4 years ago

@tyomitch: did you try directly start without a VM (step 2) directly? I'm not sure this will work in all cases e.g. if the packaging folder is in C:\ while the wkhtmltopdf source is in D:\ -- if you do it from step 2 directly, then there shouldn't be any problem.

ashkulz commented 4 years ago

Closing this, as I'm not sure I want to support WIndows hosts starting a nested VM.