search

wkhtmltopdf / packaging

Packaging of wkhtmltopdf releases
https://wkhtmltopdf.org/downloads.html#stable
311 stars 142 forks source link

Allow to disable or override the QEMU platform to use #86

Closed nstuardod closed 3 years ago

nstuardod commented 3 years ago

Add the --no-qemu and --use-qemu <PLATFORM> command line arguments to the build script, so it's possible to do builds on non-x86 hosts.

nstuardod commented 3 years ago

How about:

By default, the build system assumes the host system runs on x86-64 GNU/Linux and it will use QEMU to emulate non-x86 platforms within Docker. If you are building on a non-x86 host, you can use the --no-qemu to disable QEMU entirely, or --use-qemu <PLATFORM> to force the use of a specific build of QEMU if you're cross building for a different platform. The platform argument follows the format os/arch(/variant).

ashkulz commented 3 years ago

Thanks for implementing this :tada:

nstuardod commented 3 years ago

Thanks. However there were two unmerged (last-minute) commits that should be added.

ashkulz commented 3 years ago

I did a squash-merge, so all the commits should already be in it?

nstuardod commented 3 years ago

Now they are. Thanks again.