search

wkillerud / some-sass

Improved support for SCSS, Sass indented and SassDoc. Workspace awareness and full support for Sass modules.
https://wkillerud.github.io/some-sass/
60 stars 6 forks source link

Tab completion merges namespace definition in Vue SFC style blocks inside Sublime Text #230

Closed niksy closed 2 months ago

niksy commented 2 months ago

In which editor is this a problem?

Sublime Text

Describe the bug

Following https://github.com/wkillerud/some-sass/issues/226, there is another similar issue if you’re using Sass language server for Vue SFC style blocks.

Namespace definition gets merged to autocompleted field instead of leaving dot.

Language server selector needs to be set to source.scss | text.html.vue so language server gets applied to Vue SFC.

Take a look at the video:

https://github.com/user-attachments/assets/330626c8-147d-4ca6-b17c-c6d88d879182

What's the expected result?

Dot separating namespace definition is left behind instead of being removed after completion.

Link to minimal reproducible example

No response

Participation

wkillerud commented 2 months ago

Hmm, that's unfortunate. In VSCode I had to work around Vue and friends to avoid duplicating the ..

https://github.com/wkillerud/some-sass/blob/22a1e91ecaf4016b2db7a29c4f2be8edac5e946c/packages/language-services/src/features/do-complete.ts#L1176-L1179

I'll look into it, we'll probably need yet another setting 😅

wkillerud commented 2 months ago

Version 1.8.1 fixes this problem. It also makes the somesass.completion.afterModule and somesass.completion.beforeVariable settings obsolete (the internals of the code suggestions have been reworked so they're no longer needed).

niksy commented 2 months ago

Yup, this is it, thanks!