search

wkillerud / some-sass

Improved support for SCSS, Sass indented and SassDoc. Workspace awareness and full support for Sass modules.
https://wkillerud.github.io/some-sass/
60 stars 6 forks source link

Indented comments don't have correct syntax highlighting #250

Open wkillerud opened 1 month ago

wkillerud commented 1 month ago

In which editor is this a problem?

Visual Studio Code

Describe the bug

For Sass indented, indented-style comments don't get the correct syntax highlighting.

What's the expected result?

Indented comments should work the same as non-indented.

Link to minimal reproducible example

https://gist.github.com/wkillerud/1bf8ebb0d1c9db10bf4c7bca45805f13

Participation

wkillerud commented 1 month ago

The syntax highlighting is based on the TextMate grammar in vscode-extension/languages/. These lines to be specific:

https://github.com/wkillerud/some-sass/blob/b88b5f7937bc4b85e6968f3b7fa2a1d345d18f96/vscode-extension/languages/sass.tmLanguage.json#L933-L957

The problem is to figure out how to end the comment block.

I did an experiment with semantic tokens to perhaps fix this issue outside of the TextMate grammar, but it didn't seem to have any visual effect.