search

wking / oci-command-line-api

A command-line API specification for opencontainers/specs
Apache License 2.0
2 stars 3 forks source link

Use RFC 2119's keywords (MUST, MAY, ...) #9

Closed wking closed 8 years ago

wking commented 8 years ago

The spec landed an RFC 2119 approach in opencontainers/specs#260. There is already some discussion on a previous version of this commit here, as well as some related RFC 2119 work in #8.

mikebrow commented 8 years ago

@wking just need one minor fix see above.

wking commented 8 years ago

On Fri, Dec 11, 2015 at 08:11:54AM -0800, Mike Brown wrote:

@wking just need one minor fix see above.

I just pushed 52ca435 → 6f5ae34, rebasing around the just-landed #8 and fixing the “to its stdout” typo 1.

wking commented 8 years ago

On Fri, Dec 11, 2015 at 08:39:43AM -0800, W. Trevor King wrote:

I just pushed 52ca435 → 6f5ae34, rebasing around the just-landed #8 and fixing the “to its stdout” typo [1].

And I just pushed 6f5ae34 → be67069, resolving a conflict with the just-landed #11 (since the typo fix in the 6f5ae34 commit maybe reset the two-workday clock on this one).

wking commented 8 years ago

On Fri, Dec 11, 2015 at 05:04:58PM -0800, W. Trevor King wrote:

And I just pushed 6f5ae34 → be67069, resolving a conflict with the just-landed #11 (since the typo fix in the 6f5ae34 commit maybe reset the two-workday clock on this one).

Merged with a @mikebrow Signed-off-by, since I fixed the typo he pointed out 1, and all the rest of his comments were LGTMs ;).