wking / rss2email

open-source tool for Windows, Mac OS and UNIX for getting news from RSS feeds in email
http://pypi.python.org/pypi/rss2email/
GNU General Public License v2.0
268 stars 48 forks source link

Changes to smtp config options and dropping SSLv3. #48

Open sudhirkhanger opened 9 years ago

sudhirkhanger commented 9 years ago

As per instructions one has to use use-smtp = true to use smtp which doesn't seem to be valid anymore. It resulted in extra configuration key: use-smtp. I changed email-protocol = smtp to see if it works but it gave following errors.

could not connect to mail server smtp.gmail.com:465
cause: [SSL: TLSV1_ALERT_DECODE_ERROR] tlsv1 alert decode error (_ssl.c:598)
reason: TLSV1_ALERT_DECODE_ERROR
could not connect to mail server smtp.gmail.com:465
cause: [SSL: TLSV1_ALERT_DECODE_ERROR] tlsv1 alert decode error (_ssl.c:598)
reason: TLSV1_ALERT_DECODE_ERROR
could not connect to mail server smtp.gmail.com:465
cause: [SSL: TLSV1_ALERT_DECODE_ERROR] tlsv1 alert decode error (_ssl.c:598)
reason: TLSV1_ALERT_DECODE_ERROR

Also the default protocol for smtp auth is SSLv3. Are folks still using SSLv3 after POODLE.

PS:- The older version of rss2email config had all options explained in the config file which was very helpful.

### Options for configuring rss2email ###

# The email address messages are from by default:
DEFAULT_FROM = "bozo@dev.null.invalid"

#1: Send text/html messages when possible.
#0: Convert HTML to plain text.
HTML_MAIL = 1

#1: Only use the DEFAULT_FROM address.
#0: Use the email address specified by the feed, when possible.
FORCE_FROM = 0

#1: Receive one email per post.
#0: Receive an email every time a post changes.
TRUST_GUID = 1

#1: Generate Date header based on item's date, when possible.
#0: Generate Date header based on time sent.
DATE_HEADER = 0

# A tuple consisting of some combination of
# ('issued', 'created', 'modified', 'expired')
# expressing ordered list of preference in dates 
# to use for the Date header of the email.
DATE_HEADER_ORDER = ('modified', 'issued', 'created')
firecat53 commented 9 years ago

Summary: Sending via Gmail's SMTP is broken with Python 3.4

I'm not sure if you are using Python 3.4, but there appears to be a change in how the smtp connection is called. See this StackOverflow question. Basically, the host and port need to be provided in the smtplib.SMTP constructor instead of in smtp.connect(). I'm not sure if that same method can be used with python < 3.4 or not.

Also, it's confusing in the config file whether or not ssl should be set to true for Gmail SMTP sending. I would have guessed it would until I looked at the code. Perhaps a note in the config file?

This may be the issue the OP had...if not, I can open a new issue for this.

Thanks! Scott

Ekleog commented 3 years ago

Hello,

This repository has been deprecated for a few years now, and has been replaced by https://github.com/rss2email/rss2email .

If this issue is still relevant to you, and not fixed with v3.12.2, could you please reopen the issue there?

Cheers, Leo