wking / rss2email

open-source tool for Windows, Mac OS and UNIX for getting news from RSS feeds in email
http://pypi.python.org/pypi/rss2email/
GNU General Public License v2.0
273 stars 48 forks source link

"looks like HTML" warning broken #83

Closed jwilk closed 3 years ago

jwilk commented 8 years ago

In rss2email/feed.py there's this code to warn when the server sent you HTML:

http_headers = parsed.get('headers', {})
...
if 'html' in http_headers.get('content-type', 'rss'):
    _LOG.warning('looks like HTML: {}'.format(self))
    warned = True

But at least with feedparser v5.1.3, http_headers is a normal dict with keys that were not lower-cased. So this check won't trigger most of the time.

Ekleog commented 4 years ago

Hello,

This repository has been deprecated for a few years now, and has been replaced by https://github.com/rss2email/rss2email .

If this issue is still relevant to you, and not fixed with v3.12.2, could you please reopen the issue there?

Cheers, Leo

jwilk commented 3 years ago

Closing in favor of https://github.com/rss2email/rss2email/issues/160.