wkiri / MTE

Mars Target Encyclopedia
Apache License 2.0
5 stars 0 forks source link

Copy parser files from parser-indexer to this repository #21

Closed wkiri closed 2 years ago

wkiri commented 2 years ago

Since our parser capabilities no longer depend on Solr, it would make sense to migrate the relevant parser scripts (and issues) to the MTE repository (leaving current versions of the parser scripts as-is in the parser-indexer repo).

Then, we can also remove the dependency on the parser-indexer repo in this repository.

stevenlujpl commented 2 years ago

In order to copy the parser scripts to the MTE repo, we need to accomplish the following steps:

stevenlujpl commented 2 years ago

@wkiri I've copied the parser scripts to the parser branch of the MTE repo. In addition, I also copied the util scripts log_utils.py and io_utils.py to the MTE repo. I slightly modified the util scripts to remove the methods that we don't need in MTE repo.

I tested the lpsc_parser.py script, and everything works as expected. I think from now on we can use the lpsc_parser.py in the MTE repo.

Currently, we have three util scripts (name_utils.py, log_utils.py, and io_utils.py) in the MTE repo. Do we want to merge them together in one util script?

wkiri commented 2 years ago

I think it is fine to have separate utils scripts.