wkjarosz / hdrview

A simple research-oriented image viewer with an emphasis on examining and comparing high-dynamic range (HDR) images, and including minimalistic editing and tonemapping capabilities.
Other
291 stars 11 forks source link

Some questions about Hello ImGui and communication #119

Open pthom opened 6 months ago

pthom commented 6 months ago

Hello, I really like your project, and its dear-imgui branch makes an excellent demonstration of Hello ImGui capabilities. I have several questions related to this.

Can I refer to your project and display it as an example for HelloImGui / ImGui Bundle?

The fact that your project compiles to Emscripten seamlessly and is able to load images even on a browser does interest me quite a lot.

If you agree (and when you are ready), I would like to consider the possibility to add it to a gallery inside Hello ImGui documentation and maybe also inside the interactive manual for ImGui Bundle, with a link to a live Emscripten version.

As a matter of fact, the way that you setup the application (see below) is extremely readable and could serve as an additional hands-on tutorial for Hello ImGui.

Below is the code extract I would like to show in a possible documentation/gallery page: https://github.com/wkjarosz/hdrview/blob/881d56c71047bd5b84315dc813535fe160eac3bc/src/app.cpp#L152-L334

There is no rush. You can tell me yes or no, or tell me that you prefer to wait until you added some more features to it.

About the logger

I like the way you did the layout for the logger in the application. Would you mind if someday I take some inspiration from it in order to update the logger inside Hello ImGui?


We can discuss this inside this GitHub issue or you can contact me by email if you prefer.

Thanks!

wkjarosz commented 5 months ago

Sorry for my delay and thanks for the offer.

Yes, I would be interested in this once the new branch is in a state that I feel could be shared more broadly. I had hoped to get more time in the last month to make progress, but unfortunately haven't yet.

Things work pretty well on macOS, but I'll need to get things working reliably in emscripten and windows in the ci and deployment github actions.