search

wklumpen / equity-pulse-web

Equity Pulse is a web application and visualization platform using Flask+D3 to support equity and access calcualtions for TransitCenter/SSR/SF2 Work
4 stars 0 forks source link

Chart notes for DC have an extra . at the end #94

Closed mlbtc closed 3 years ago

mlbtc commented 3 years ago

There's an extra period on the chart note for 3rd, 4th, 5th & 6th chart on the DC Story page, likely due to the placement of "Washington D.C." at the end of the sentence.

Ex: "Data shows a typical weekday for the Urban Core of Washington D.C.."

wklumpen commented 3 years ago

This one is hilariously tricky, as it requires manually checking if we are in the dc region.

A super easy fix is to swap the region name and subset: "Data shows a typical weekday for the region_name Urban Core."

Would this work for you?

wklumpen commented 3 years ago

Also: Urban core shouldn't be capitalized, should it?

mlbtc commented 3 years ago

Yep, this definitely works! It should be consistent and I think we've capitalized it when it appears on other data labels. So keep it capitalized.

wklumpen commented 3 years ago

Done.