search

wknoben / MARRMoT

Modular Assessment of Rainfall-Runoff Models Toolbox - Matlab code for 47 conceptual hydrologic models
GNU General Public License v3.0
110 stars 54 forks source link

Doubling up on GR4J's X4 parameter #54

Closed wknoben closed 4 months ago

wknoben commented 5 months ago

X4 is multiplied inside the uh_2_full function:

https://github.com/wknoben/MARRMoT/blob/7f86958540012b06a4555fb0530d62b1ece28622/MARRMoT/Models/Unit%20Hydrograph%20files/uh_2_full.m#L34

But also in the model function:

https://github.com/wknoben/MARRMoT/blob/7f86958540012b06a4555fb0530d62b1ece28622/MARRMoT/Models/Model%20files/m_07_gr4j_4p_2s.m#L63

Problem: we end up with a time base for the hydrograph of 22X4

Solution: remove the part in uh_2_full. This keeps the implementation closest to the Perrin et al. (2003) paper.

Contributors: Nyree Campion, Keirnan Fowler