search

wkulhanek / openshift-prometheus

Repository for all things related to Prometheus on OpenShift
51 stars 41 forks source link

Updates to prometheus and node exporter #1

Closed sabre1041 closed 7 years ago

sabre1041 commented 7 years ago

Updates to prometheus and node exporter

@wkulhanek please review

wkulhanek commented 7 years ago

@sabre1041 doesn't iptables-save mess up the whole firewall with then persistent rules for any service that might be defined? That is usually a big problem... and why I added the rule manually.

Also OPENTLC environments only have 4Gi volumes. And finally Brian Brasil said in an OpenShift Commons briefing that Prometheus is designed for ephemeral storage. So maybe we don't need a PVC at all.

sabre1041 commented 7 years ago

@wkulhanek Updated PR

Went through and updated README based on this solutions article.

Regarding persistent storage, I have experienced a few issues while testing related to PV's and explained in this issue. Removed use of PV's in prometheus template to use emptyDir