search

wkumler / RaMS

R-based access to Mass-Spectrometry data
Other
20 stars 7 forks source link

check namespace when reading in mzML #18

Closed ethanbass closed 8 months ago

ethanbass commented 1 year ago

I think this resolves the namespace issue mentioned in #17. Not sure if we should also call the checkNamespace function in grabMzxmlData. I only incorporated it here into grabMzmlData.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.13 :warning:

Comparison is base (3ffa687) 85.31% compared to head (e5545c8) 85.19%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18 +/- ## ========================================== - Coverage 85.31% 85.19% -0.13% ========================================== Files 5 5 Lines 1171 1175 +4 ========================================== + Hits 999 1001 +2 - Misses 172 174 +2 ``` | [Impacted Files](https://codecov.io/gh/wkumler/RaMS/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=William) | Coverage Δ | | |---|---|---| | [R/grabMSdataCode.R](https://codecov.io/gh/wkumler/RaMS/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=William#diff-Ui9ncmFiTVNkYXRhQ29kZS5S) | `87.56% <33.33%> (-0.90%)` | :arrow_down: | | [R/grabMzmlFunctions.R](https://codecov.io/gh/wkumler/RaMS/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=William#diff-Ui9ncmFiTXptbEZ1bmN0aW9ucy5S) | `93.03% <100.00%> (+0.02%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=William). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=William)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

wkumler commented 1 year ago

Neat! Thanks for putting in the work. I'll do some extra tests on my own shortly and check out the mzXML implementation and merge if it all looks okay.