Begin work to get phytool ready for Fedora inclusion.

wkz / phytool

Linux MDIO register access

GNU General Public License v2.0

143 stars 75 forks source link

Begin work to get phytool ready for Fedora inclusion. #14

Closed smooge closed 6 months ago

smooge commented 6 months ago

Fedora and other distros add a lot of flags to uncover possible problems with code. Added in an error check on asprintf as it could fail and cause problems.

wkz commented 6 months ago

I'm not opposed to merging these error checks, but the formatting of this change needs some work.

Please set your editor to use linux kernel style indentation, and update this PR with the results.

smooge commented 6 months ago

omg. I just looked at that and realized my mistake with all that white space. I am fixing this.

smooge commented 6 months ago

I have some other proposed changes which came up in the package review but want to make sure I am following how you would like them. Is it better to make more PR's or first make issues and then PR's

smooge commented 6 months ago

And I have made a bodge of this PR again by adding in the Makefile changes I had found. My apologies

wkz commented 6 months ago

No worries :smile:

Please create PRs directly, there's no need to have an issue for it as well.

smooge commented 6 months ago

I have tried to clean out the problems but it is a lot of differnet ones now combined. I can open a new PR with this all squashed or just live with this. The Makefile changes for dealing with md5sum and a missing bin will be a different PR