LSF plugin

[mglev1n]

Prework

• [x] I understand and agree to the Contributor Code of Conduct.
• [x] I have already submitted a discussion topic or issue to discuss my idea with the maintainer.

Related GitHub issues and pull requests

• Ref: #4

Summary

This draft pull request includes an initial implementation of an LSF plugin. This uses the new args_terminate() method from https://github.com/wlandau/crew.cluster/commit/223b0dcbba7d69db1fc6b5d15bdf31f5a7255ca6 to support correct job termination.

Job submission in this implementation doesn't work correctly yet. Just as job termination requires an extra argument - eg: bkill -J job-name, job submission requires the < argument in order to specify job parameters from a file/script - eg: bsub < submission_script.sh.

I propose implementing an args_launch() or args_submit() method similar to args_terminate() in order to provide the required functionality.

[codecov-commenter]

Codecov Report

Patch coverage: 99.24% and project coverage change: -0.19 :warning:

Comparison is base (98d385f) 100.00% compared to head (4d08836) 99.81%.

:exclamation: Current head 4d08836 differs from pull request most recent head 877f897. Consider uploading reports for the commit 877f897 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #7 +/- ## =========================================== - Coverage 100.00% 99.81% -0.19% =========================================== Files 7 9 +2 Lines 397 529 +132 =========================================== + Hits 397 528 +131 - Misses 0 1 +1 ``` | [Impacted Files](https://app.codecov.io/gh/wlandau/crew.cluster/pull/7?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau) | Coverage Δ | | |---|---|---| | [R/crew\_launcher\_cluster.R](https://app.codecov.io/gh/wlandau/crew.cluster/pull/7?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui9jcmV3X2xhdW5jaGVyX2NsdXN0ZXIuUg==) | `100.00% <ø> (ø)` | | | [R/crew\_launcher\_lsf.R](https://app.codecov.io/gh/wlandau/crew.cluster/pull/7?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui9jcmV3X2xhdW5jaGVyX2xzZi5S) | `98.95% <98.95%> (ø)` | | | [R/crew\_controller\_lsf.R](https://app.codecov.io/gh/wlandau/crew.cluster/pull/7?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui9jcmV3X2NvbnRyb2xsZXJfbHNmLlI=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[wlandau]

Thanks so much for getting started! I added an args_launch() method to crew_class_launcher_cluster and merged it into this PR, plus an LSF-specific args_launch() for your PR. I will have a more detailed look today.

[mglev1n]

Thanks for the additions - this implementation seems to work (at least in my environment)!

[wlandau]

I also have a couple more requests:

1. Would you be willing to add yourself as a co-author (role = "aut") in the DESCRIPTION file? You can add yourself with person() between my name and that of my employer.
2. A news entry would be great, crediting you with the contribution.
3. The pkgdown job is having trouble because of _pkgdown.yml. Would you add the LSF functions and classes? I like to keep those lists in alphabetical order.

[wlandau]

I will just resolve these conflicts and then merge.