search

wlandau / crew

A distributed worker launcher
https://wlandau.github.io/crew/
Other
123 stars 4 forks source link

For reproducible test result #114

Closed shikokuchuo closed 1 year ago

shikokuchuo commented 1 year ago

Prework

Related GitHub issues and pull requests

Summary

Amends patch for test as per comment: https://github.com/wlandau/crew/issues/112#issuecomment-1706236934

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (5cfd904) 100.00% compared to head (54b75e9) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #114 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 22 22 Lines 1284 1284 ========================================= Hits 1284 1284 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wlandau commented 1 year ago

Would you see if 0a5ccfe12dbfec010d230287ddcdb5b2414b63ed fixes the original testing issue on your end? The goal of the test is to verify that the task used the correct seed, so I'm afraid set.seed() inside the task of the command defeats the purpose.

shikokuchuo commented 1 year ago

Hmm seems I automatically closed this when I was trying to pull from your latest branch... but that's fine as your latest commit does indeed fix this. Thanks!