wlandau / crew

A distributed worker launcher
https://wlandau.github.io/crew/
Other
129 stars 4 forks source link

use new developer interface in mirai #118

Closed shikokuchuo closed 1 year ago

shikokuchuo commented 1 year ago

Prework

Related GitHub issues and pull requests

Summary

As described in the issue. This replaces all instances where the internal package environments are referenced with the appropriate call to nextget()

closes #117

shikokuchuo commented 1 year ago

Have done. Just curious - is this a matter of style or for other reasons? As all your imports are declared individually there should be no scope for conflict. Are there edge cases I should be aware of? The call to :: has some negligible overhead :)

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (948c339) 100.00% compared to head (366aa36) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #118 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 22 22 Lines 1315 1315 ========================================= Hits 1315 1315 ``` | [Files Changed](https://app.codecov.io/gh/wlandau/crew/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau) | Coverage Δ | | |---|---|---| | [R/crew\_client.R](https://app.codecov.io/gh/wlandau/crew/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui9jcmV3X2NsaWVudC5S) | `100.00% <100.00%> (ø)` | | | [R/crew\_launcher.R](https://app.codecov.io/gh/wlandau/crew/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui9jcmV3X2xhdW5jaGVyLlI=) | `100.00% <100.00%> (ø)` | | | [R/utils\_mirai.R](https://app.codecov.io/gh/wlandau/crew/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui91dGlsc19taXJhaS5S) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.

:loudspeaker: Have feedback on the report? Share it here.

wlandau commented 1 year ago

Thanks!

Even though those functions are listed in @importFrom, I like the extra defensive programming of ::. And as a general practice, it helps prevent accidental conflicts between functions I define internally in crew and functions from other packages.

shikokuchuo commented 1 year ago

Yep, that's sensible. Just wondered in case there were cases I didn't know of where R itself can get confused...