Closed shikokuchuo closed 1 year ago
Have done. Just curious - is this a matter of style or for other reasons? As all your imports are declared individually there should be no scope for conflict. Are there edge cases I should be aware of? The call to ::
has some negligible overhead :)
Patch coverage: 100.00%
and no project coverage change.
Comparison is base (
948c339
) 100.00% compared to head (366aa36
) 100.00%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks!
Even though those functions are listed in @importFrom
, I like the extra defensive programming of ::
. And as a general practice, it helps prevent accidental conflicts between functions I define internally in crew
and functions from other packages.
Yep, that's sensible. Just wondered in case there were cases I didn't know of where R itself can get confused...
Prework
Related GitHub issues and pull requests
Summary
As described in the issue. This replaces all instances where the internal package environments are referenced with the appropriate call to
nextget()
closes #117