No more need for 'seconds_exit' argument

wlandau / crew

A distributed worker launcher

https://wlandau.github.io/crew/

Other

129 stars 4 forks source link

No more need for 'seconds_exit' argument #125

Closed shikokuchuo closed 1 year ago

shikokuchuo commented 1 year ago

Prework

[x] Read and agree to the Contributor Code of Conduct and contributing guidelines.
[x] If there is already a relevant issue, whether open or closed, comment on the existing thread instead of posting a new issue.

Description

As the argument 'exitlinger' has been retired at mirai as of version 0.10.0.9005 with the issue resolved https://github.com/shikokuchuo/mirai/discussions/63#discussioncomment-7068719.

shikokuchuo commented 1 year ago

FYI for the package to build on r-universe I think you just need to add links to mirai and nanonext in a packages.json in an wlandau.r-universe.dev repo as per https://ropensci.org/blog/2021/06/22/setup-runiverse/#the-packagesjson-registry-file

wlandau commented 1 year ago

As the argument 'exitlinger' has been retired at mirai as of version 0.10.0.9005 with the issue resolved https://github.com/shikokuchuo/mirai/discussions/63#discussioncomment-7068719.

Amazing! I will deprecate seconds_exit.

FYI for the package to build on r-universe I think you just need to add links to mirai and nanonext in a packages.json in an wlandau.r-universe.dev repo as per https://ropensci.org/blog/2021/06/22/setup-runiverse/#the-packagesjson-registry-file

Thanks for the tip, I will try that.

shikokuchuo commented 1 year ago

FYI for the package to build on r-universe I think you just need to add links to mirai and nanonext in a packages.json in an wlandau.r-universe.dev repo as per https://ropensci.org/blog/2021/06/22/setup-runiverse/#the-packagesjson-registry-file

Thanks for the tip, I will try that.

I think you also need to include your own packages, or they get deleted.. :) https://github.com/r-universe/wlandau/commit/6c248d1ceb5ad150b763399fe17e6d74568f8729