wlandau / crew

A distributed worker launcher
https://wlandau.github.io/crew/
Other
123 stars 4 forks source link

make daemons error human readable + no longer use sha1 for random names #130

Closed shikokuchuo closed 1 year ago

shikokuchuo commented 1 year ago

Prework

Related GitHub issues and pull requests

Summary

PR to make the daemons error less cryptic. At the same time, now nanonext >= 0.10.1 is on CRAN, removes sha1() in generating the random names.

codecov-commenter commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (42e0d8e) 100.00% compared to head (bc7d6bd) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #130 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 23 23 Lines 1494 1494 ========================================= Hits 1494 1494 ``` | [Files](https://app.codecov.io/gh/wlandau/crew/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau) | Coverage Δ | | |---|---|---| | [R/crew\_random\_name.R](https://app.codecov.io/gh/wlandau/crew/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui9jcmV3X3JhbmRvbV9uYW1lLlI=) | `100.00% <100.00%> (ø)` | | | [R/utils\_mirai.R](https://app.codecov.io/gh/wlandau/crew/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui91dGlsc19taXJhaS5S) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shikokuchuo commented 1 year ago

ready to merge

wlandau commented 1 year ago

Thanks