search

wlandau / crew

A distributed worker launcher
https://wlandau.github.io/crew/
Other
129 stars 4 forks source link

Small changes for argument name in latest mirai #168

Closed shikokuchuo closed 6 months ago

shikokuchuo commented 6 months ago

Prework

Summary

In two places you use call_mirai_ with the argument 'aio'.

Whilst I have ignored the aesthetics until now, I am now making the arguments consistent between nanonext and mirai as the use of 'aio' in mirai may be confusing and this is now just a generic 'x'. This comes about as I directly assign the functions from nanonext in mirai to avoid an additional R function call.

As this function will only ever take one argument, I'd think it's both practically and stylistically fine to call without the argument name.

This change will need to be on CRAN before I make the next mirai release. Thanks!

shikokuchuo commented 6 months ago

Also noticed you don't use nanonext::.unresolved() any more so that import can be removed.

wlandau commented 6 months ago

Looks good, thanks for the heads up. I can re-release crew next Wednesday.

wlandau commented 5 months ago

Just submitted crew version 0.9.3 to CRAN with these changes.