search

wlandau / crew

A distributed worker launcher
https://wlandau.github.io/crew/
Other
129 stars 4 forks source link

Major refactor #87

Closed wlandau closed 1 year ago

wlandau commented 1 year ago

Prework

Related GitHub issues and pull requests

Summary

On the whole, these changes seriously improve the package. The logic and design are dramatically improved, and even speed improves a little.

Best of all, crew is far more ready to integrate with the dispatcher as discussed in https://github.com/shikokuchuo/mirai/discussions/60. The crux was separating auto-scaling responsibilities from task management responsibilities. In other words, crew is (almost) capable of sending the launcher object to the mirai dispatcher process while still managing the mirai task objects on the client process.

Unfortunately, there are breaking changes for the internals of third-party launcher plugins like in crew.cluster. I plan to release crew.cluster and then crew in a way that will hopefully this transition as smooth as possible.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.20 :tada:

Comparison is base (8804fea) 99.79% compared to head (3275e34) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #87 +/- ## =========================================== + Coverage 99.79% 100.00% +0.20% =========================================== Files 19 20 +1 Lines 993 988 -5 =========================================== - Hits 991 988 -3 + Misses 2 0 -2 ``` | [Impacted Files](https://app.codecov.io/gh/wlandau/crew/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau) | Coverage Δ | | |---|---|---| | [R/crew\_client.R](https://app.codecov.io/gh/wlandau/crew/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui9jcmV3X2NsaWVudC5S) | `100.00% <100.00%> (ø)` | | | [R/crew\_controller.R](https://app.codecov.io/gh/wlandau/crew/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui9jcmV3X2NvbnRyb2xsZXIuUg==) | `100.00% <100.00%> (ø)` | | | [R/crew\_controller\_group.R](https://app.codecov.io/gh/wlandau/crew/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui9jcmV3X2NvbnRyb2xsZXJfZ3JvdXAuUg==) | `100.00% <100.00%> (ø)` | | | [R/crew\_controller\_local.R](https://app.codecov.io/gh/wlandau/crew/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui9jcmV3X2NvbnRyb2xsZXJfbG9jYWwuUg==) | `100.00% <100.00%> (ø)` | | | [R/crew\_launcher.R](https://app.codecov.io/gh/wlandau/crew/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui9jcmV3X2xhdW5jaGVyLlI=) | `100.00% <100.00%> (ø)` | | | [R/crew\_launcher\_local.R](https://app.codecov.io/gh/wlandau/crew/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui9jcmV3X2xhdW5jaGVyX2xvY2FsLlI=) | `100.00% <100.00%> (ø)` | | | [R/crew\_schedule.R](https://app.codecov.io/gh/wlandau/crew/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui9jcmV3X3NjaGVkdWxlLlI=) | `100.00% <100.00%> (ø)` | | | [R/utils\_daemons.R](https://app.codecov.io/gh/wlandau/crew/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui91dGlsc19kYWVtb25zLlI=) | `100.00% <100.00%> (ø)` | | | [R/utils\_names.R](https://app.codecov.io/gh/wlandau/crew/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Landau#diff-Ui91dGlsc19uYW1lcy5S) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.