search

wlangstroth / vim-racket

vim bundle for Racket
MIT License
234 stars 60 forks source link

Conditionally unmapping mappings #80

Closed minond closed 1 year ago

minond commented 1 year ago

Conditionally unmapping nmap <buffer> K and nmap <buffer> K which are conditionally mapped in the first place (when no previous mapping exists.)

minond commented 1 year ago

I'm just seeing https://github.com/wlangstroth/vim-racket/pull/79 -- closing this PR in favor of that one. Any technical reason that PR hasn't been merged yet though? In any case, thanks for the great plugin!

benknoble commented 1 year ago

I'm just seeing https://github.com/wlangstroth/vim-racket/pull/79 -- closing this PR in favor of that one. Any technical reason that PR hasn't been merged yet though? In any case, thanks for the great plugin!

I can't answer for @wlangstroth , but I haven't seen a lot of activity here. The files that ship with Vim come from my fork https://github.com/benknoble/vim-racket, which already has a similar fix using silent!.

minond commented 1 year ago

Hey @benknoble, thanks for the reply. That's awesome, I've switched over to your fork.

wlangstroth commented 1 year ago

You absolutely should use @benknoble 's fork. Pass it on.