search

wlanslovenija / PiplMesh

A social info portal for wireless networks.
http://dev.wlan-si.net/wiki/PiplMesh
Other
40 stars 19 forks source link

Fixed some things. Started adding comments #303

Closed mfrlin closed 11 years ago

mfrlin commented 11 years ago

I've fixed some minor things and started adding comments. Would appreciate some feedback before I loose too much time heading in wrong direction.

Can't figure out how to trigger addComment() when submiting a comment via generated form. Can't figure out how to trigger deletePost() via delete_link. JavaScript help desired :)

mitar commented 11 years ago

Please update from main repository. This pull request cannot be merged automatically.

mitar commented 11 years ago

OK. Why code style changes? This is not really something you do in collaborative project where there is already established code style. So please explain and/or change back.

mitar commented 11 years ago

Please update from main repository.

mitar commented 11 years ago

Please update from main repository to be able to merge.

mitar commented 11 years ago

OK. You should really learn how to merge and work with the repository.

This pull request became garbage. I am closing it. Please open new one, clean, and without those bad commits.

Also, in each pull request concentrate only on one thing. So, fixing some things should be one pull request. Comments another.

It is nothing wrong if pull request is not finished when you start it, make it to the point to which you know to do it and then ask for help. But this currently is simply unreadable so I do not even know what is wrong with it or where you have problems.