search

wlanslovenija / PiplMesh

A social info portal for wireless networks.
http://dev.wlan-si.net/wiki/PiplMesh
Other
40 stars 19 forks source link

Weather,clouds and panorama layer for google maps #310

Closed Gitek1 closed 11 years ago

Gitek1 commented 11 years ago

Added checkbox for weather, clouds and panorama layer.

Gitek1 commented 11 years ago

Check it.

mitar commented 11 years ago

I don't see clouds working.

Why all labels on the map are hidden when you enable weather? I would leave labels on, even if things become more crowded, because layers in general it would be useful to have labels on.

Gitek1 commented 11 years ago

Fixed.

I see clouds when zoomed out. I removed them in last commit, I guess they are not that usable.

I think labels cant be shown in weather mode, there is no option in documentation. Documentation says ( https://developers.google.com/maps/documentation/javascript/layers#WeatherLayer ): "When the weather layer is enabled and the zoom level is set to 12 or lower, administrative labels, such as the names of streets or regions, will be disabled on your map"

mitar commented 11 years ago

I would have cloud layer. If not, it looks interesting. :-) It is already optional. But also later on we can make people be able to configure which layers to see.

mitar commented 11 years ago

OK, then if this is how weather layer behaves, let it be.

Can you maybe add a tooltip over the layer entry in the list on the right? Then we could have a tooltip like "Hides labels on zoom level 12 or lower."

Gitek1 commented 11 years ago

Fixed.

I don't think weather option needs a tooltip, clouds may be more problematic.

mitar commented 11 years ago

I don't think weather option needs a tooltip, clouds may be more problematic.

A tooltip explaining why labels disappeared? I think this is useful because if people enable more layers at the same time, to understand which one hide labels.

What is the issue with clouds?

mitar commented 11 years ago

One more thing I found out. It is better to use .attr when defining new DOM in the code, and .prop when you want to set or access current values after DOM was in use.

Gitek1 commented 11 years ago

Fixed.

The thing with clouds is that they don't show, even if enabled, when you are zoomed in. When user clicks the weather something happens no matter what zoom level the user is on.

mitar commented 11 years ago

So it is not possible to configure tooltip ("title" DOM attribute) for clouds and weather. Something like:

mitar commented 11 years ago

Otherwise good.

Gitek1 commented 11 years ago

Added tooltips