search

wlanslovenija / django-tastypie-mongoengine

MongoEngine support for django-tastypie.
Other
73 stars 59 forks source link

Updated support for tastypie 0.9.12 #43

Closed leo-naeka closed 11 years ago

leo-naeka commented 11 years ago

Tastypie 0.9.12 has been released 4 days ago, bringing bugfixes and several improvements. I think we should support this version by now.

danigosa commented 11 years ago

Tastypie is speeding up development and upgrading fast with awesome changes, they are now at 0.9.14 with must have improvements and fixes. @leo-naeka @mitar any branch to start finding the compatibilty issues?

leo-naeka commented 11 years ago

The current stable tastypie is 0.9.13. I have not tested it with this branch of tastypie-mongoengine but as changes mainly concern security issues with the XML serializer, no issues should occur. Please keep us informed otherwise.

mitar commented 11 years ago

Hi guys. I am really glad to see this enthusiasm about this library. I am currently completely in some other projects (and even frameworks) so would any of you would be interested in co-maintaining this library? I see that you depend on it and it is much easier to maintain something if you are using it personally, which currently I am not doing.

The other thing is also that I was thinking we should move to BSD license. AGPLv3 is too restricting probably for a library. (There is no Lesser AGPLv3 which would be something I would be personally interested in. So that any changes to the library are required to be published, but not that projects using the library have to be AGPLv3, too.)

What do you think?

mitar commented 11 years ago

Merged. Thanks.

mitar commented 11 years ago

And it seems that it works nicely with 0.9.15, too.

leo-naeka commented 11 years ago

Hi mitar, Firstly, I should be able to co-maintain the lib (not sure I have all the time needed however) and secondly, concerning the licence BSD or MIT seems good for me and are indeed a way more appropriate for a lib.

danigosa commented 11 years ago

Hi all,

I don't have many time to really co-maintain the library as Leo because it seems he has digged into the code much more than me, but I use it in production so I will do the real testing on it to unfold bugs, and as long as I got deeper in the library I will send patches as far as I could. As said before, BSD or MIT would be nice for my project too!

On Tue, Apr 2, 2013 at 10:30 AM, leo-naeka notifications@github.com wrote:

Hi mitar, Firstly, I should be able to co-maintain the lib (not sure I have all the time needed however) and secondly, concerning the licence BSD or MIT seems good for me and are indeed a way more appropriate for a lib.

— Reply to this email directly or view it on GitHubhttps://github.com/mitar/django-tastypie-mongoengine/pull/43#issuecomment-15762797 .

[image: Inline image 1]

""""May the Force be With You"""" Dani ~ CTO ([image: Inline image 1]@danigosa)

[image: Inline image 1] http://www.infantium.com/

◄Ѧ Code Is Poetry Ѧ► http://www.codeispoetry.me/

*

Dani Gonzalez* Founder & COO & CTO

Gran Via 19-20 Oficinas ITnet http://maps.google.com/maps?q=Gran+Via+19-20%2COficinas+ITnet%2CHospitalet+Llobregat%2CBarcelona+08902%2CEspa%F1a&hl=enHospitalet Llobregat, Barcelona 08902 España

*[image: Inline image 2] Infantium Developing Minds http://www.infantium.com/

Mobile: _+34653729071 Twitter: @danigosa *Linlkedin:_http://es.linkedin.com/in/danigosa Facebook: http://www.facebook.com/dani.infantium

leo-naeka commented 11 years ago

Hi @mitar,

This test I added covered a use case I have when embedded documents are handled on server side and should not be managed from the API. Initially the test added in 3f2ace9 was failing and used to reveal that readonly was not available with EmbeddedDocumentField, this have been fixed in 284a465. Your changes made in 9828bd7 indeed test that the document is really readonly, this is a good point, not covered before and makes the test really useful since our library now supports readonly EmbeddedDocuments.

Concerning your comment, I don't think tastypie should return a failure status code: tastypie's behavior is to simply ignore readonly fields on full_hydrate. Considering a PATCH with only a readonly k/v pair is a voided PATCH, if the conventions are to return and HTTP 2xx, we should return it. It's the responsability to requesters to process useful requests.

Btw, sorry for the late answer.

Edit: I have (very) quickly read RFC 5789 and found no mentions of required data. This is a non-sense btw...

mitar commented 11 years ago

OK. I removed TODO.