wlanslovenija / django-tastypie-mongoengine

MongoEngine support for django-tastypie.
Other
73 stars 59 forks source link

TastyPie 0.9.15 compatibility #48

Closed danstovall closed 11 years ago

danstovall commented 11 years ago

Added the _forlist parameter to dehydrate methods, passed _forlist into subsequent calls to dehydrate_related for TastyPie 0.9.15 compatibility

mitar commented 11 years ago

Hm, tests fail because of MongoEngine updates?

mitar commented 11 years ago

Please sign-off here in a comment.

danstovall commented 11 years ago

Thanks, it was actually changes to tastypie, not mongoengine. That should do it.

But speaking of mongoeengine they released 0.8.RC4 recently and there are compatibility issues with it as well. Have you looked into them at all? The main one I know of is in the _reset_collection method of MongoEngineResource, the call to self._meta.queryset._reset_already_indexed() raises an AttributeError because they completely removed the _reset_already_indexed method from QuerySet

mitar commented 11 years ago

No, I am saying that because of the MongoEngine changes tests didn't go through.

mitar commented 11 years ago

And now even TastyPie support is not yet complete, it looks. See: https://travis-ci.org/mitar/django-tastypie-mongoengine/jobs/7162267 I don't have time anymore today for this, so if you want to look into this, it would be great. You can trigger CI test by making a pull request and then see the results. And then you can update the results. It would be great to get it to green.

danstovall commented 11 years ago

There has been some discussion of the ImportError in that failing test in the tastypie repo: https://github.com/toastdriven/django-tastypie/pull/681

I'll see if I can find out anymore about it. Thanks