search

wlanslovenija / django-tastypie-mongoengine

MongoEngine support for django-tastypie.
Other
73 stars 59 forks source link

Fixed some import errors, pep8 conformance #6

Closed aparajita closed 12 years ago

aparajita commented 12 years ago

There were some errors in the imports that caused execution errors. Mainly importing a module name that was the same as a parameter name.

mitar commented 12 years ago

Thanks, but please do not change code style when you do pull requests (even if it is PEP8).

mitar commented 12 years ago

(So no those additional empty lines.)

mitar commented 12 years ago

Otherwise good.

aparajita commented 12 years ago

Made the changes you requested, thanks for doing this project. In the future I recommend using pyflakes to lint your code, it immediately caught the imports shadowing parameter names.

mitar commented 12 years ago

Thanks! I will. I also had in mind to check with djangolint, but I am not sure if it is good for libraries.

Anyway, if you want, you can run it yourself and see if there are any further things to fix.

Please sign-off this pull request.

aparajita commented 12 years ago

Signed-off-by: Aparajita Fishman aparajita@aparajita.com

mitar commented 12 years ago

Thanks.