search

wlanslovenija / django-tastypie-mongoengine

MongoEngine support for django-tastypie.
Other
73 stars 59 forks source link

Bump supported mongoengine version to 0.8.4 #65

Closed prymitive closed 10 years ago

prymitive commented 10 years ago

Currently django-tastypie-mongoengine depends on mongoengine>=0.8.1,<0.8.2, can you bump that to 0.8.4? It seems to be working just fine with it. Are there any know issues with 0.8.4?

mitar commented 10 years ago

This was the issue: https://github.com/MongoEngine/mongoengine/issues/381

Are all tests passing now?

prymitive commented 10 years ago

I see that this issue is still open on mongoengine side (waiting for 0.9) and the pull request with possible fix for it on django-tastypie-mongoengine is not merged, so I guess not.

This only affects my travis tests, so it's not a big issue for me.

mitar commented 10 years ago

the pull request with possible fix for it on django-tastypie-mongoengine is not merged, so I guess not.

Which pull request?

prymitive commented 10 years ago

https://github.com/mitar/django-tastypie-mongoengine/pull/62

This states that it fixes #57, which is the issue in django-tastypie-mongoengine that is caused by https://github.com/MongoEngine/mongoengine/issues/381, unless I'm reading it wrong, I just did a quick look at those issues.

mitar commented 10 years ago

No, that is not related.

kepler commented 7 years ago

Seems like this has been fixed: https://github.com/MongoEngine/mongoengine/issues/381#issuecomment-97609685