search

wlanslovenija / django-tastypie-mongoengine

MongoEngine support for django-tastypie.
Other
73 stars 59 forks source link

Allow versions of MongoEngne greater than 0.8.1 #68

Open naftulikay opened 10 years ago

naftulikay commented 10 years ago

I'm not able to use django-tastypie-mongoengine because it presently limits the maximum version of MongoEngine to 0.8.1. This allows it to use any version of MongoEngine >= 0.8.1.

mitar commented 10 years ago

Have you seen that tests fail with versions greater than 0.8.1? This means you might be able to install it, but it will not work correctly. There is a reason why version is limited: so that you get a working version.

See this ticket for more information: https://github.com/MongoEngine/mongoengine/issues/381

mitar commented 10 years ago

BTW, this pull request is missing changing of limits on versions for Travis CI testing. So testing is still done on 0.8.1, while you removed the limits. Remove the limits in .travis.yaml as well and you will see tests fail.

naftulikay commented 10 years ago

I'll have to look into this.

If you can give me an idea of why tests fail in particular with future versions of MongoEngine, I might work on a bigger pull request to patch it and get things working and get all tests passing.

mitar commented 10 years ago

I linked the MongoEngine ticket. Tests fail because they broke one thing.

Seraf commented 10 years ago

Hello @mitar and @rfkrocktk ,

What is the status of this issue ? In my requirements.txt, I need to use mongoengine >= 0.8.6 and use django_tastypie_mongoengine too but it fails due to : error: Installed distribution mongoengine 0.8.7 conflicts with requirement mongoengine>=0.8.1,<0.8.2

Thanks !

naftulikay commented 10 years ago

Nothing has been changed AFAIK. You must use mongoengine == 0.8.1 to use django_tastypie_mongoengine.

mitar commented 10 years ago

Please comment and urge on this ticket for MongoEngine to fix their codebase: https://github.com/MongoEngine/mongoengine/issues/381

Seraf commented 9 years ago

@mitar @rfkrocktk Hi guys, as the fix is planned for 0.9 and I think we won't have it for a long time, is it possible to create a tagged release on github without the mongoengine requirement ? : https://pip.pypa.io/en/latest/reference/pip_install.html#requirements-file-format

It will allow those who need last mongoengine to use it, even if there's a bug and not having problem with requirements.txt file.