Channel allocation module.

wlanslovenija / nodewatcher

A modular open networks growing platform.

http://nodewatcher.net/

Other

63 stars 20 forks source link

Closed CdavM closed 8 years ago

CdavM commented 8 years ago

This PR was created to discuss implementation details of the channel allocation module.

kostko commented 8 years ago

I've fixed Travis CI in development, please rebase/merge.

kostko commented 8 years ago

Something does not look right, why are the commits duplicated?

CdavM commented 8 years ago

hmm I must have messed up the merge. will try again.

CdavM commented 8 years ago

@mitar The fixtures are not being loaded on the Travis image, but it works locally (without the full path). Can you take a look?

mitar commented 8 years ago

Interesting. Can you temporary try to run it in verbose mode? So add verbose flag to your .travis.yaml file and push it here.

CdavM commented 8 years ago

@mitar, can you do a code review?

mitar commented 8 years ago

Otherwise it looks pretty good. Just minor things. I do not know about the algorithm, though. I hope that it works. ;-)

CdavM commented 8 years ago

@mitar I made all the changes requested. One more code review :-) ?

mitar commented 8 years ago

LGTM.

CdavM commented 8 years ago

OK so let's merge it :-)

mitar commented 8 years ago

Great! Great job!!!