search

wlanslovenija / nodewatcher

A modular open networks growing platform.
http://nodewatcher.net/
Other
63 stars 20 forks source link

Update map.html #31

Closed mitjajez closed 7 years ago

mitjajez commented 7 years ago

Map renders into same id as title

Map

this should fix it

mitar commented 7 years ago

Why opening a new pull request? Why not updating the old one?

And no, this is also not good enough. Because you have also to change the JavaScript code to point it to this new coordinate.

I think you should clone the code locally and edit there in your branch, instead of using GitHub to do so.

Also, you should probably test the code before making a pull request and saying that this is a fix. The whole point of a contribution is that you make the effort to test it so that we can then distribute the work. Just editing the file without testing means that then I have to test it, so how much is then this really helpful?