Add Unifi UAP and UAP AC Lite device descriptors

[robimarko]

Pull request to add Unifi UAP and newer UAP AC Lite device descriptors. This time properly made in separate branch.

[mitar]

Can you really please name those descriptors well? I still do not understand what they are for? Which exactly models?

[robimarko]

Look, I have named them as per product name. I don't know hot to name the differently.

The one that you requested name to be changed to Ubiquiti AP AC Lite device descriptor is this one https://www.ubnt.com/unifi/unifi-ap-ac-lite/

And the second one name UAP is this, actually for UAP and UAP-LR models. https://www.ubnt.com/unifi/unifi-ap/

[mitar]

I know of:

• UniFi AP
• UniFi AP LR
• UniFi AP Pro
• UniFi AP AC HD
• UniFi AP AC LR
• UniFi AP AC Lite

So the one in this pull request are UniFi AP and UniFi AP AC Lite?

[robimarko]

The first one is AP AC Lite and the second one is UniFi AP and Unifi AP LR since they use the exactly same image and only differ in 2x2 vs 3x3 antennas on LR model.

[mitar]

So can you make three classes? For all those three devices? You can also extend Unifi AP LR from UniFi AP class and just override the antennas, if it is different?

We want to be more precise than just wrapping filenames from OpenWrt. We want to know for each model/device, even if they share the same binary.

[mitar]

For antennas, you can check in their datasheets:

https://dl.ubnt.com/datasheets/unifi/UniFi_AC_APs_DS.pdf

For UniFi AP AC Lite it says: "(2) Dual-Band Antennas, 3 dBi Each"

So it has two antennas, and the same antenna is used for both 2.4 GHz and 5 GHZ, and it is 3 dbi.

Pro has 3 dual-band antennas.

[robimarko]

There is no need for additional AP LR class since according to datasheet AP and AP LR have the same antennas. Integrated 3 dBi Omni (Supports 2x2 MIMO with Spatial Diversity) as per UBNT datasheet. It looks only the output power is different

[mitar]

Polarization for those antennas seems to be dual. angle_vertical seems closer to 120 degrees, based on this diagram.

[mitar]

There is no need for additional AP LR class since according to datasheet AP and AP LR have the same antennas.

So just extend the class and change the identifier and description and this is it then.

We want to have precise information and know which device is which so that we could in the future compute coverage automatically and things like that.

[robimarko]

I have extended the class and added AP LR descriptor. Also, I have modified gain to be correct and vertical angle like you pointed out.

[robimarko]

Just figured out that I had wrong device profile for making defined. Now it is per LEDE profile. @kostko @mitar Any chance of merging?

[robimarko]

I have squashed previous commits into one.

[kostko]

Please rebase on development and fix conflicts.

[robimarko]

Will do.

[robimarko]

@kostko Rebased and conflict should be fixed

[kostko]

Please add the devices: prefix to the commit message.

[robimarko]

@kostko Changes made as you requested and prefix added.