search

wlav / CPyCppyy

Other
23 stars 20 forks source link

`CPYCPPYY_VERSION_HEX` is not really hexadecimal #15

Closed guitargeek closed 6 months ago

guitargeek commented 7 months ago

The CPYCPPYY_VERSION_HEX is not really hexadecimal: https://github.com/wlav/CPyCppyy/blob/master/include/CPyCppyy/API.h#L28

#define CPYCPPYY_VERSION_HEX 0x011200

If this is meant to be like PY_VERSION_HEX, should it not be 0x010c00?

wlav commented 6 months ago

Actually yes; and really 0x010c10 at this point. I forgot that this existed, so haven't updated patch numbers. I don't think it's used anywhere and I can't find why it was introduced (it seems to have been a bit of a random part of a larger commit).

I updated it in the repo.

guitargeek commented 6 months ago

Thanks!