search

wlav / CPyCppyy

Other
23 stars 20 forks source link

Use `mp_vectorcall` instead of `fVectorCall` #20

Closed guitargeek closed 8 months ago

guitargeek commented 8 months ago

See https://github.com/wlav/CPyCppyy/pull/19#issuecomment-1989231119

wlav commented 8 months ago

No, I guess not.

Reading the Python sources as to how tp_vectorcall is actually used, it's not a replacement for a vectorcall data member of the instance. Instead, it serves the same purpose but for type objects. I.e. to turn the constructor into a vector call. It may still help performance a bit for those, but there are no memory savings here.

guitargeek commented 8 months ago

Oh, okay! Well, feel free to close this issue is you want! Or leave it here as a reminder there might be marginal performance gains possible here.