search

wlav / CPyCppyy

Other
23 stars 20 forks source link

Correcly forward `control` flag to InstancePtrConverter #22

Closed guitargeek closed 3 months ago

guitargeek commented 6 months ago

Closes https://github.com/wlav/cppyy/issues/221, if the change in memory policy was accidental.

This fixes the memory test in the synchronization PR: https://github.com/root-project/root/pull/14507

guitargeek commented 4 months ago

Hi @wlav, do you need any more information from my side before merging this? I have a reproducer for the problem in the associated issue

wlav commented 4 months ago

These and other PRs need tests. It's best practice to have tests but it's also in your own interest as it will pre-empt regressions.

guitargeek commented 3 months ago

You are right! I have opened a PR with a unit test that will pass once this is merged.