search

wlav / CPyCppyy

Other
23 stars 20 forks source link

Do not use file globbing in the build system #32

Open guitargeek opened 2 months ago

guitargeek commented 2 months ago

This makes the build configuration more robust to added and removed files.

See also the analogous PR in ROOT, as well as the corresponding Jira ticket:

Like this, we also don't need to "comment out" whole source files with preprocessor macros, like the TPyClassGenerator. This also helps ROOT, which requires these sources, because then the sources can be used as-is.

wlav commented 2 months ago

I wouldn't uncomment the TPyClassGenerator file as it really can't compile at this point. It accesses ROOT headers directly rather than clingwrapper APIs. The point of that file was to make Python classes usable from Cling. It's a cute feature, but no-one really ever cared about it, since callbacks (through a C++ base class) are easier to deal with.