CPPMethod::GetArgMatchScore now runs CompareMethodArgType on ref, const ref and ptr of the requested type

wlav / CPyCppyy

Other

23 stars 20 forks source link

CPPMethod::GetArgMatchScore now runs CompareMethodArgType on ref, const ref and ptr of the requested type #8

Closed aaronj0 closed 1 year ago

aaronj0 commented 1 year ago

Part of getting the right __overload__ match on the numba side when the args are passed by ref/ptr to an overload @sudo-panda @wlav

aaronj0 commented 1 year ago

@sudo-panda @wlav @vgvassilev Improved this fix by departing from generating fixed strings and avoiding multiple calls to CompareMethodArgType. The restructered ArgMatch algorithm in cppyy-backend (this PR) can now handle any combination of ref/const(or any qualifier) ref/ptr types using clang::QualType functions.

aaronj0 commented 1 year ago

Closing since changes in CPyCppyy are no longer required