search

wlepinski / angularjs-facebook-sdk

Integration between AngularJS and Facebook SDK for Javascript.
http://wlepinski.github.io/angularjs-facebook-sdk/
MIT License
36 stars 7 forks source link

Facebook API v 2.x support #5

Closed mevjak closed 9 years ago

mevjak commented 9 years ago

According to Facebook API changelog there are some changes in Facebook SDK loading:

1) The location https://connect.facebook.net/en_US/all.js become https://connect.facebook.net/en_US/sdk.js in v 2.0 and above.

2) There is a new parameter in FB.init() that indicates what version of the API will be used

See: https://developers.facebook.com/docs/apps/changelog#v2_0_js_sdk

IMHO the fix would require some small changes in facebook_config_provider service.

wlepinski commented 9 years ago

Will take a look as soon as possible. In the meantime, @mevjak if you could provide a pull request for that would be awesome.

mevjak commented 9 years ago

Pull request submitted - https://github.com/wlepinski/angularjs-facebook-sdk/pull/6.

wlepinski commented 9 years ago

Hey, Thanks for the PR. I'll take a look as soon as possible.

wlepinski commented 9 years ago

Merged on 02c1bd0.