wlevine / clamz

Command-line downloader for Amazon MP3
GNU General Public License v3.0
2 stars 0 forks source link

clamz downloads, and saves as read only on Arch #10

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. download files
2. they show locked (even though they do play)
3.

What is the expected output? What do you see instead?
That the files are chmodded to 644.  That they are read only (444) for all
groups.

What version of the product are you using? On what operating system?
0.2-1
Arch x86_84
Please provide any additional information below.

Original issue reported on code.google.com by kperkins...@gmail.com on 4 Apr 2009 at 7:07

GoogleCodeExporter commented 9 years ago
I downloaded the code, and looked in download.c, and think that if line 414
  dl->outfd = open(dl->filename, O_WRONLY | O_APPEND | O_CREAT, 0444);
is changed to:
  dl->outfd = open(dl->filename, O_WRONLY | O_APPEND | O_CREAT, 0644);
that would solve this bug.  
Unless you need that 0444 for some reason that I don't understand.
I've attached the file with the change, and may try it myself to see if it 
works.

Original comment by kperkins...@gmail.com on 4 Apr 2009 at 7:20

Attachments:

GoogleCodeExporter commented 9 years ago
I get this too. Minor, but would appreciate it getting fixed (trying the patch 
right
now).

Original comment by doorkno...@gmail.com on 16 May 2009 at 3:33

GoogleCodeExporter commented 9 years ago
The patch works fine, and I haven't had any problems with it.  

Original comment by kperkins...@gmail.com on 16 May 2009 at 10:57

GoogleCodeExporter commented 9 years ago
Patch works for me too BTW

Original comment by doorkno...@gmail.com on 16 May 2009 at 5:20

GoogleCodeExporter commented 9 years ago
Hmm.  The idea here, I think, was to create the files read-only so that I would 
be
less likely to delete or overwrite them by mistake.  Maybe this should be a
configuration option?

Original comment by Benjamin...@gmail.com on 17 Jul 2009 at 6:38

GoogleCodeExporter commented 9 years ago
Done in 0.3.  In addition to being potentially less confusing, files need 
read-write
permission in order for resuming downloads to work.

Original comment by Benjamin...@gmail.com on 1 Apr 2010 at 4:59