Is get_range_slices_by_time complete?

wlloyd / eiger

A research fork of cassandra that provides causal+ consistency, read-only transaction, and write-only transaction across all the servers in each datacenter.

Apache License 2.0

77 stars 15 forks source link

Is get_range_slices_by_time complete? #5

Closed winstone closed 9 years ago

winstone commented 9 years ago

Original Cassandra does not provide the get_range_slices_by_time function, which you have implemented in Eiger. However, when I read the code, I found the thriftifyColumnFamilyAtTime function with comment that indicates it is still in progress, but the underlying comment codes are also fine. So does get_range_slices_by_time function works well with the underlying codes or are there still any bugs in the function?

wlloyd commented 9 years ago

I believe the commented out code in that function is incomplete and would not work properly if uncommented.