Closed wlpotter closed 2 years ago
@wlpotter this is looking really good! Thank so much. I've noticed a couple of issues in my spot-checking.
Beyond these couple of quick things, I think the transform is working really well and we'll just need to wait for the schema updates to take things further.
Thanks Will!
@dlschwartz Thanks for these!
I think once we sort out the few remaining decisions, and once we've implemented batch changes, this transform should be ready to go.
FYI, I should have mentioned this above, but the script was working on my adaptation of the Google sheet, here: https://github.com/wlpotter/csv-to-srophe/blob/main/in/test/persons_test.csv
Closing this as I've made issues for the dates, and everything else requires CSV data changes.
@dlschwartz I have the first outputs of the persons transform, here: https://github.com/wlpotter/csv-to-srophe/tree/main/test/out/csv-tests/persons
The first two to look at are
These are the two sample records I used to build the persons transform module. So any glaring errors there are likely to be shared across the other data.
Then it would be worthwhile to spot-check several other records to identify issues.
Unfortunately, we can't rely here on the schema validation as we haven't updated that yet.
Finally, here are a few notes of known issues and problems
@resp="http://syriaca.org
even if they should be sourced@ana
or@role
attribute as I couldn't remember if we had decided for sure to include a "#syriaca-anonymous" value for those.Feel free either to post other issues you notice here or create separate issues for them.