search

wlpotter / csv-to-srophe

A set of XQuery modules for converting CSV data to Srophe-compliant TEI XML records. Developed for Syriaca.org
GNU General Public License v3.0
1 stars 1 forks source link

Nested locations in places should instead be tei:relation elements #52

Closed wlpotter closed 11 months ago

wlpotter commented 1 year ago

Note may need clarification on the predicates needed for these relationships

wlpotter commented 1 year ago

@dlschwartz have the predicates for these relationships been finalized? Are these here: https://docs.google.com/spreadsheets/d/1NoRkNsxO34P9xfojcgkfDvW2LqJnvwGz0qTwktuNWes/edit?pli=1#gid=287444409 ?

dlschwartz commented 1 year ago

The schema currently expects "skos:broader". Now that I re-read your note in the spreadsheet we might want to discuss dcterms:isPartOf again. Perhaps I'm not entirely clear on the entailment issues.

wlpotter commented 1 year ago

I will use skos:broader for now but will leave this as an open question to return to

dlschwartz commented 1 year ago

That sounds best, thanks.

wlpotter commented 1 year ago

Note to self on how to fix:

Instead of using relationN.skosBroader, use relationN.containedWithin and add an additional option to the switch statement in csv2srophe:build-relation-element (ca. ll. 910). This will let you add the necessary @type="contained-within" attribute

wlpotter commented 11 months ago

Fixed

wlpotter commented 11 months ago

Found a bug here. Looks the the schema requires a tei:desc as child of the relation?

For Edessa this is what we have (looking at https://github.com/srophe/syriaca-data/blob/2023.02.21_schemaWork/data/places/tei/78.xml#L359C1-L361C32):

<relation type="contained-within" ref="skos:broader" active="http://syriaca.org/place/78" passive="http://syriaca.org/place/145" source="#bib78-1" to="0641">
  <desc xml:lang="en"><placeName ref="http://syriaca.org/place/145">Osrhoene</placeName></desc>
</relation>

Need to update to add the tei:desc with place name and URI...