wlpotter / csv-to-srophe

A set of XQuery modules for converting CSV data to Srophe-compliant TEI XML records. Developed for Syriaca.org
GNU General Public License v3.0
1 stars 1 forks source link

Abstracts need `@corresp` attribute for corresponding seriesStmt idnos #65

Closed wlpotter closed 9 months ago

wlpotter commented 9 months ago

Cf. https://github.com/srophe/syriaca-data/issues/1166 for schema changes.

I'm thinking the best way to handle is to put in the config files and reference as a global variable?

wlpotter commented 9 months ago

@dlschwartz I might want your help thinking through our preferred way to handle this in record generation as I'm not sure where in the process we want to specify which URIs are added to the @corresp.

Declaring in the config file causes problems for, e.g., persons since the same CSV might contain a mix of author and saint records.

Declaring in the CSV puts too much burden on the data providers (JEG in this case) to know the seriesStmt URIs, and how to use them. Plus that's one more column to deal with

One option would be to add as a final step getting the list of applied seriesStmt idnos and then adding the @corresp attribute to the abstract(s). This wouldn't work if we wanted to only apply the URIs for JEG to new records, leaving the validation errors as signals that we need to write abstracts for the new places (or review the JEG ones manually). I also don't like how this muddies the separation between transform from CSV into skeleton XML data records and then apply entity-specific templates, which is how it currently works.

What would be most helpful to clarify is how the output should look (i.e., should it be valid and have all the necessary URIs), or do we want to have the user(s) specify and then manually review invalid records to apply additional series URIs?

wlpotter commented 9 months ago

Decision: the URIs of all seriesStmts should be added to the @corresp attribute.

wlpotter commented 9 months ago

Fixed!