search

wlrfx / scenefx

A drop-in replacement for the wlroots scene API that allows wayland compositors to render surfaces with eye-candy effects
MIT License
83 stars 8 forks source link

Improve process to pass box shadow color. #18

Closed Shinyzenith closed 6 months ago

Shinyzenith commented 1 year ago

The fact that box_shadow color a float * instead of just a float [4] is problematic. Wrapping that in FFI is clunky because essentially in zig I need to wrap it as: *f32[4] which might as well just be f32[4]. Not to mention other languages where that kind of pointer arithmetic is usually not suggested. Eg: Python

Why can't we approach it as just float [4]?

ErikReider commented 6 months ago

We could use the wlr_render_color struct instead :)

ErikReider commented 6 months ago

Lol, apparently I fixed this back in January xD