search

wlrfx / scenefx

A drop-in replacement for the wlroots scene API that allows wayland compositors to render surfaces with eye-candy effects
MIT License
81 stars 8 forks source link

Fix some issues affecting compositor usage #45

Open WillPower3309 opened 7 months ago

WillPower3309 commented 7 months ago

A few points from the scenefx patch notes on dwl:

NOTE: Some GTK apps are being cut off when they have shadows enabled. You can use the shadow_ignore_list option to prevent shadows from being rendered on those apps

NOTE: Blur doesn't work on windows with opacity set (opacity_active, opacity_inactive)

NOTE: In DWL's Makefile scenefx must be placed before wlroots, e.g. PKGS = scenefx wlroots wayland-server ...

wochap commented 7 months ago

Hi, I'm the author of the scenefx patch

NOTE: Some GTK apps are being cut off when they have shadows enabled. You can use the shadow_ignore_list option to prevent shadows from being rendered on those apps

Regarding the note above, I just wanted to point out that DWL uses wlr_scene_subsurface_tree_set_clip to prevent apps from overflowing their available space, and that the usage of wlr_scene_subsurface_tree_set_clip with scenefx causes some GTK apps to look cut off.

Screenshoots 

Here, I used the wlr_scene_subsurface_tree_set_clip function to clip all apps at 250x250
Personally, my guess is that wlr_scene_subsurface_tree_set_clip doesn't work as expected for GTK3 apps that have size hints
BTW, DWL doesn't listen to size hints

![](https://i.imgur.com/FPeH4vq.png)

Shadow off:
![](https://i.imgur.com/lJHqROP.png)

Shadow on:
![](https://i.imgur.com/ZDIVHXO.png)
WillPower3309 commented 2 months ago

Hi, I'm the author of the scenefx patch

NOTE: Some GTK apps are being cut off when they have shadows enabled. You can use the shadow_ignore_list option to prevent shadows from being rendered on those apps

Regarding the note above, I just wanted to point out that DWL uses wlr_scene_subsurface_tree_set_clip to prevent apps from overflowing their available space, and that the usage of wlr_scene_subsurface_tree_set_clip with scenefx causes some GTK apps to look cut off.

Screenshoots 

Here, I used the wlr_scene_subsurface_tree_set_clip function to clip all apps at 250x250
Personally, my guess is that wlr_scene_subsurface_tree_set_clip doesn't work as expected for GTK3 apps that have size hints
BTW, DWL doesn't listen to size hints

![](https://i.imgur.com/FPeH4vq.png)

Shadow off:
![](https://i.imgur.com/lJHqROP.png)

Shadow on:
![](https://i.imgur.com/ZDIVHXO.png)

Does https://github.com/wlrfx/scenefx/pull/56 fix this? :)