search

wlstyy / adns-python

Automatically exported from code.google.com/p/adns-python
0 stars 0 forks source link

adns 1.2 api breakage #2

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Originally submitted by mrueckert@suse.de

hi,

On 2006-05-31 11:15:27 +0100, Ian Jackson wrote:
> > Marcus Rueckert writes ("adns 1.2 api breakage"):
>> > > i just updated the adns package and it broke adns-python.
>> > > in adns.h you renamed adns__rrt_typemask to adns_rrt_typemask.
>> > > was this intentionally? if so i will mail my patch to the adns-python
>> > > author.
> > 
> > Yes.  This isn't written down anywhere, but the identifiers with `__'
> > in them are intended for private use inside adns and should probably
> > not be used by adns-python.  I made this change when I found that
> > software outside the adns library needed it to deal properly with the
> > new `unknown-by-adns rr type' feature; by renaming this identifier I
> > was declaring it public.
> > 
> > Are there other names with `__' that you're using ?

(i just see my editor fscked the pasting :| sorry for that. I will repaste it.)
[[[
$ grep adns__ *c
adnsmodule.c:   { "internalmask", adns__qf_internalmask },
adnsmodule.c:   { "deref", adns__qtf_deref },
adnsmodule.c:   { "mail822", adns__qtf_mail822 },
adnsmodule.c:   adns_rrtype td = answer->type & adns__qtf_deref;
]]]

On 2006-05-31 13:14:13 +0100, Ian Jackson wrote:
> > This doesn't look good.  In particular, it looks like this attempts to
> > compose query type codes from pieces.  This isn't supported by adns;
> > query codes other than the ones set up in adns.h may not work properly
> > and may even cause assertion failures, etc.

atm i build the python bindings with a small patch that renamed the 2
occurences of the adns__rrt_typemask. (patch attached and CC'ed the
author of the python bindings.)

thanks for your help so far.

    darix

Original issue reported on code.google.com by farcep...@gmail.com on 2 Dec 2006 at 5:54

Attachments:

GoogleCodeExporter commented 9 years ago 
Not applying this just yet. The patch currently breaks adns-1.1 and earlier.
Unfortunately there is no good or obvious way to detect the adns version at 
compile-time.

Original comment by farcep...@gmail.com on 2 Dec 2006 at 6:31

GoogleCodeExporter commented 9 years ago 
Fixed in r9

Original comment by farcep...@gmail.com on 31 Dec 2006 at 6:08